Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Felix Singer, Fred Reitberger, Jason Glenesk, Jeff Daly, Johnny Lin, Jonathan Zhang, Lance Zhao, Lean Sheng Tan, Martin Roth, Matt DeVillier, Nico Huber, Patrick Rudolph, Raul Rangel, Tim Chu, Tim Wawrzynczak, Vanessa Eusebio.
Felix Held has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/76128?usp=email )
Change subject: acpi: Move HPET generation to a common location
......................................................................
Patch Set 13:
(1 comment)
File src/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/76128/comment/75fd0774_48b473f2?usp... :
PS13, Line 134: depends on HAVE_ACPI_TABLES
It would warn, but I'm surprised (after testing this) that the return code is still 0.
i wonder if it would be better to have a HAVE_HPET Kconfog option to arch/x86/Kconfig and use that as condition in acpi/Makefile.mk. then we can drop the whole ACPI_HPET option and don't have to deal with the depends on HAVE_ACPI_TABLES thing and the ACPI table will still only be generated when HAVE_ACPI_TABLES is set due to how things are done in acpi/Makefile.mk
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76128?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I38b9962a8d568267356256a3edc51348b9417e20
Gerrit-Change-Number: 76128
Gerrit-PatchSet: 13
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Sun, 18 Aug 2024 19:45:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com