Jan Samek has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75806?usp=email )
Change subject: drv/i2c/pi608gp: Fix style ......................................................................
drv/i2c/pi608gp: Fix style
In commit e59f18bf29a8 ("drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)"), there were some suggestions after it's been already merged.
This patch addresses the points regarding the code style and comments.
BUG=none TEST=Build OK, no behavioral changes in the pi608gp driver, console logs without changes.
Change-Id: I5fc54708e0085fea4bd1f2fbf2afb400d2ccbd46 Signed-off-by: Jan Samek jan.samek@siemens.com --- M src/drivers/i2c/pi608gp/pi608gp.c 1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/75806/1
diff --git a/src/drivers/i2c/pi608gp/pi608gp.c b/src/drivers/i2c/pi608gp/pi608gp.c index 9d63f85..2c61a80 100644 --- a/src/drivers/i2c/pi608gp/pi608gp.c +++ b/src/drivers/i2c/pi608gp/pi608gp.c @@ -102,7 +102,7 @@ }
/* Retrieve back the value from the received SMBus packet in big endian order. */ - *val = read_be32((void *) buf); + *val = read_be32((void *)buf);
return CB_SUCCESS; } @@ -122,7 +122,7 @@ };
/* Insert register value to write in BE order after the header. */ - write_be32((void *) &buf[4], val); + write_be32((void *)&buf[4], val);
/* Perform the register write */ ret = smbus_block_write(dev, PI608GP_CMD_BLK_WR, sizeof(buf), buf); @@ -134,8 +134,9 @@ return CB_SUCCESS; }
-static enum cb_err pi608gp_reg_update(struct device *dev, uint8_t port, uint32_t reg_addr, - uint32_t and_mask, uint32_t or_mask) +static enum cb_err +pi608gp_reg_update(struct device *dev, uint8_t port, uint32_t reg_addr, uint32_t and_mask, + uint32_t or_mask) { uint32_t val;
@@ -153,7 +154,7 @@
static void pi608gp_init(struct device *dev) { - const uint8_t port = 0; /* Only port 0 is being configured */ + const uint8_t port = 0; /* Only the upstream port is being configured */ struct drivers_i2c_pi608gp_config *config = dev->chip_info; uint8_t amp_lvl, deemph_lvl;