Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29393 )
Change subject: src/soc/intel/braswell/include/soc/irq.h: Set bit 7 of PIRQ register to disable ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/29393/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29393/3//COMMIT_MSG@7 PS3, Line 7: src/soc/intel/braswell/include/soc/irq.h: Set bit 7 of PIRQ register to disable That's not what's done in the commit. Rephrase to "fix MACRO ..." ?
Same below, you don't touch any register.