Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36208 )
Change subject: security/vboot: Add vboot callbacks to support EC software sync ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36208/13/src/security/vboot/ec_sync... File src/security/vboot/ec_sync.c:
https://review.coreboot.org/c/coreboot/+/36208/13/src/security/vboot/ec_sync... PS13, Line 268: burst = pdata_max_size - sizeof(*params); Actually, this does have to take into account sizeof(struct ec_host_request). See https://review.coreboot.org/cgit/coreboot.git/tree/src/ec/google/chromeec/ec..., where the ec_params_* and any extra data gets put into the LPC port space after the EC host request structure, so 256 bytes is all that can be sent over LPC at one time.