Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42062 )
Change subject: src/*: Update makefiles to exclude x86 code from non-x86 verstage ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42062/3/src/drivers/pc80/pc/Makefil... File src/drivers/pc80/pc/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/3/src/drivers/pc80/pc/Makefil... PS3, Line 11: verstage-y += i8254.c
Can we come up with a syntax something like: […]
That seems reasonable. I think we need an intermediate value, something like verstage-x86_32_64-y, that evaluates as true for both x86_32 and x86_64, but that's not a big issue.
https://review.coreboot.org/c/coreboot/+/42062/3/src/lib/Makefile.inc File src/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/3/src/lib/Makefile.inc@50 PS3, Line 50: verstage-$(CONFIG_COLLECT_TIMESTAMPS) += timestamp.c
Anything in lib/ should be arch-agnostic. […]
Yeah, this is temporary. I can add a TODO to remove it once I have the timestamps implemented.
https://review.coreboot.org/c/coreboot/+/42062/3/src/soc/amd/common/block/pc... File src/soc/amd/common/block/pci/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/3/src/soc/amd/common/block/pc... PS3, Line 4:
endif here should fix it […]
Agreed, but I think we should probably split this into two directories or control it with two separate options or something.