Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42489 )
Change subject: ACPI: Drop typedef global_nvs_t ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42489/6/src/soc/intel/denverton_ns/... File src/soc/intel/denverton_ns/include/soc/nvs.h:
https://review.coreboot.org/c/coreboot/+/42489/6/src/soc/intel/denverton_ns/... PS6, Line 51:
maybe remove those extra lines ?
Done
https://review.coreboot.org/c/coreboot/+/42489/6/src/soc/intel/xeon_sp/cpx/i... File src/soc/intel/xeon_sp/cpx/include/soc/nvs.h:
https://review.coreboot.org/c/coreboot/+/42489/6/src/soc/intel/xeon_sp/cpx/i... PS6, Line 16:
maybe remove this extra line?
Done
https://review.coreboot.org/c/coreboot/+/42489/6/src/soc/intel/xeon_sp/skx/i... File src/soc/intel/xeon_sp/skx/include/soc/nvs.h:
https://review.coreboot.org/c/coreboot/+/42489/6/src/soc/intel/xeon_sp/skx/i... PS6, Line 16:
you added an extra line
Done
https://review.coreboot.org/c/coreboot/+/42489/6/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/nvs.h:
https://review.coreboot.org/c/coreboot/+/42489/6/src/southbridge/intel/i8280... PS6, Line 101:
you added an extra line
Done
https://review.coreboot.org/c/coreboot/+/42489/6/src/southbridge/intel/i8280... File src/southbridge/intel/i82801jx/nvs.h:
https://review.coreboot.org/c/coreboot/+/42489/6/src/southbridge/intel/i8280... PS6, Line 100:
an extra line
Done