Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Meera Ravindranath.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56881 )
Change subject: mb/intel/adlrvp: Add support for DDR5 MR SKU
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/intel/adlrvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/56881/comment/61249454_b6d128d6
PS4, Line 58: case ADL_P_DDR5_2:
shouldn't this go to https://review.coreboot.org/c/coreboot/+/56881/4/src/mainboard/intel/adlrvp/... so that you don't need to add memcfg_init again ? just add board_id?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56881
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b7a96b5534d8b80776aa7578ce7c13181af7882
Gerrit-Change-Number: 56881
Gerrit-PatchSet: 4
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Comment-Date: Tue, 10 Aug 2021 15:45:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment