Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 52:
(38 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/d02473d6_82354948 PS52, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/d934b13c_0b03d7af PS52, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/67eb3b6b_624c1982 PS52, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/ed68369c_75eb0af0 PS52, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/492f925a_de009937 PS52, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/2fe5f9fd_12f75d4b PS52, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/cef4cd3c_fb0d6d03 PS52, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/3694bbb6_813ca9ee PS52, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwClock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/252950dc_4616ec38 PS52, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/588a8fdd_5b9bcc65 PS52, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/fef472db_a6d71902 PS52, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/914c5f9b_a642f6b8 PS52, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/12ec5332_83b7fdfb PS52, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/86ef5fce_f7ae3144 PS52, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/031438d0_1b450934 PS52, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/a405bf9d_68bce228 PS52, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/92728a0e_a482b6aa PS52, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/dc150c9c_26c65533 PS52, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/48e13a98_99373183 PS52, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/4107015d_545aa35a PS52, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/c8e0d50b_13f86e1a PS52, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/74b356ef_d5960773 PS52, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/161dca29_d69f7e34 PS52, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/1a795d2c_ab1e7fcd PS52, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/07e7471d_338728e9 PS52, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/c8e329e5_95465adb PS52, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/1bddce5e_9371f2ea PS52, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/14f00486_37aa0d13 PS52, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/df2f93d7_0fa08d05 PS52, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/670bee6c_0960ff20 PS52, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/cc7c526b_35aeb2dc PS52, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/27d490bc_4eccc191 PS52, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/e68273d8_79905f7f PS52, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/60f81083_6b84581c PS52, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/bd894316_0d8d1b4b PS52, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/f2e7c1e2_02dbaaf5 PS52, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/49dd1247_d1596572 PS52, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159856): https://review.coreboot.org/c/coreboot/+/23586/comment/97dac403_a6debb3d PS52, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const