Attention is currently required from: Jason Glenesk, Marshall Dawson, Julius Werner, Kyösti Mälkki, Felix Held.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58956 )
Change subject: [RFC] ChromeOS: Declare CHROMEOS_NO_GPIOS
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58956/comment/fb1911b6_3382ce4c
PS1, Line 9: Implementation of fill_lb_gpios() is not about VBOOT
I agree that bootmode.c isn't the best place to put fill_lb_gpios(). However, that doesn't justify this patch, which replaces the weak function with a Kconfig option. Please explain why we can't just move fill_lb_gpios() to somewhere else, for example, coreboot_table.c. We use weak functions a lot in coreboot. I don't see there's a benefit changing them to Kconfig options.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58956
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f1eaaeffe388a7f8a7fc2430b6593eb8298461b
Gerrit-Change-Number: 58956
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 05 Nov 2021 09:12:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment