Attention is currently required from: Filip Lewiński, Martin L Roth, Michał Żygowski.
Felix Singer has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/83385?usp=email )
Change subject: payloads/external/iPXE/Makefile: Build iPXE for EFI target if requested
......................................................................
Patch Set 1:
(1 comment)
File payloads/external/iPXE/Makefile:
https://review.coreboot.org/c/coreboot/+/83385/comment/2fd08240_9cb574e9?usp... :
PS1, Line 14: ifeq ($(CONFIG_IPXE_BUILD_EFI),y)
I think you forgot to add a Kconfig option to your commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83385?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7f247a59a65aeb18a67475d4d543f519af88aeb9
Gerrit-Change-Number: 83385
Gerrit-PatchSet: 1
Gerrit-Owner: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Comment-Date: Tue, 09 Jul 2024 22:32:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No