Attention is currently required from: Subrata Banik, Won Chung, Nick Vaccaro, Benson Leung, Prashant Malani.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61571 )
Change subject: mb/google/brya: Add custom PLD fields to devicetree for brya variants
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Since there is a lot of redundancy in these custom PLD, and we are following a standard template,
we could simplify this by adding new macros to define a PLD group.
e.g., I could see a Type-A and Type-C macros being useful
```
#define ACPI_PLD_TYPE_A(panel,horiz,grp) \
{ .visible = true, \
.panel = PLD_PANEL##_panel, \
.shape = PLD_SHAPE_HORIZONTAL_RECTANGLE, \
.horizontal_position = PLD_HORIZONTAL_POSITION#_horiz, \
.group = grp, }
#define ACPI_PLD_TYPE_C(panel,horiz,grp) \
{ .visible = true, \
.panel = PLD_PANEL##_panel, \
.shape = PLD_SHAPE_OVAL, \
.horizontal_position = PLD_HORIZONTAL_POSITION#_horiz, \
.group = grp, }
```
and then use this instead like, e.g.
```
register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, LEFT, ACPI_PLD_GROUP(1, 1))"
```
WDYT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61571
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If610e6b3c849d982345ed1b8607ffd2af105dc51
Gerrit-Change-Number: 61571
Gerrit-PatchSet: 6
Gerrit-Owner: Won Chung
wonchung@google.com
Gerrit-Reviewer: Benson Leung
bleung@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen Wisley
wisley.chen@quantatw.com
Gerrit-CC: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Won Chung
wonchung@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Benson Leung
bleung@chromium.org
Gerrit-Attention: Prashant Malani
pmalani@chromium.org
Gerrit-Comment-Date: Tue, 08 Feb 2022 16:26:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment