Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41667 )
Change subject: AGESA f14/f15tn/f16kb: Clean up buildOpts.c files ......................................................................
Patch Set 6:
(3 comments)
Overall this change looks quite good - and, considering that the built binaries do not change as you said, I just need more understanding about some options before giving it a +2
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f14/Config/PlatformInstall.h:
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... PS6, Line 210: OPTION_GFX_RECOVERY What this OPTION_GFX_RECOVERY means, and why it has been removed?
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... PS6, Line 239: OPTION_DMI More info about OPTION_DMI is also needed for review, to understand its' change from TRUE to FALSE
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Config/OptionGnbInstall.h:
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... PS6, Line 163: PcieTrainingDistributed Which algorithm is better - PcieTrainingStandard or PcieTrainingDistributed ?