Attention is currently required from: Shelley Chen, Ravi kumar, Martin Roth, mturney mturney, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52376 )
Change subject: HACK payloads: Add libpci for arm arch HACK ......................................................................
Patch Set 4:
(14 comments)
File payloads/libpayload/drivers/pci.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/091e2a76_26d1d5f1 PS4, Line 57: #define PCIE_ATU_TYPE_IO (0x2 << 0) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/9e292994_9023c087 PS4, Line 57: #define PCIE_ATU_TYPE_IO (0x2 << 0) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/7bcf3b02_af782597 PS4, Line 84: static void dw_pcie_writel_ob_unroll(void * atu_base, "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/c66368d1_29f0bbf1 PS4, Line 224: if (current_bus == 1) Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/5a57e5c2_d5001023 PS4, Line 231: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/7e8b9966_061d538f PS4, Line 248: io_size); trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/39894d97_6c53025a PS4, Line 253: u8 pci_read_config8(u32 dev, u16 reg) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/90308d21_2884904c PS4, Line 254: { trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/a6b086d5_d14c1bc6 PS4, Line 255: int val, offset = reg; trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/2187a9a0_89e42723 PS4, Line 264: qcom_read_config(NVME_PCIE_BDF(1,0,0), reg, &val, 16); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/78f1c69f_d3d18319 PS4, Line 264: qcom_read_config(NVME_PCIE_BDF(1,0,0), reg, &val, 16); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/96ce3d37_5b1eff41 PS4, Line 268: u32 pci_read_config32(u32 dev, u16 reg) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/3075a86a_226b753d PS4, Line 343: u16 reg = 0x10+ (bar * 4); need consistent spacing around '+' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964): https://review.coreboot.org/c/coreboot/+/52376/comment/9eb74d43_c9de5e78 PS4, Line 344: val = pci_read_config32(dev, reg ); space prohibited before that close parenthesis ')'