Attention is currently required from: Hung-Te Lin, Knox Chiou, Paul Menzel, Yang Wu, Yu-Ping Wu.
Xinxiong Xu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/a6575902_7a4179d8?usp... :
PS6, Line 131: BOARD_GOOGLE_SQUIRTLE
Yes if the schedule can be met, otherwise there will be 2 exceptions. […]
If we don't want Squirtle to be an exception, can we apply the same modification to Voltorb? We can add 0x7FFFFEFF to the config.star file and support both 0x7FFFFEFF and 0x7FFFFFFF in the same DTS configuration, ensuring consistency.
Since we need to add 0x7FFFFEFF to Squirtle's config.star, and also add 0x7FFFFEFF to the DTS that supports 0x7FFFFFFF, this shouldn't cause any confusion.
In that case, there will be no need to add exceptions on the coreboot side.
What do you think?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 6
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Knox Chiou
knoxchiou@google.com
Gerrit-Reviewer: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Knox Chiou
knoxchiou@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Thu, 19 Sep 2024 00:41:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Knox Chiou
knoxchiou@google.com
Comment-In-Reply-To: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com