Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41760 )
Change subject: mb/ocp/deltalake: Add FSP version to coreboot table for cbmem to display
......................................................................
Patch Set 4:
Patch Set 4:
It’s a useful feature. Can this be added to common code?
Makes sense. We should update drivers/intel/fsp2_0, we either piggy back on DISPLAY_FSP_HEADER, or make a new Kconfig item.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41760
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I579fa87028b9ed0734b2fac206daf43ecae311be
Gerrit-Change-Number: 41760
Gerrit-PatchSet: 4
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 May 2020 18:05:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment