Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31420 )
Change subject: SMBIOS: Update Processor Information structure to v3.2.0
......................................................................
Patch Set 5:
(2 comments)
Btw. what about the other two new fields?
https://review.coreboot.org/#/c/31420/5/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31420/5/src/arch/x86/smbios.c@565
PS5, Line 565: if (t->core_count2 == 0)
we just set it to 0 in line 553.
https://review.coreboot.org/#/c/31420/5/src/arch/x86/smbios.c@566
PS5, Line 566: t->core_count2 = (u16)(t->core_count);
no cast needed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31420
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1861615eff904f13029b8d038ffcf3de2d2bfc2a
Gerrit-Change-Number: 31420
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 Feb 2019 09:34:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment