Attention is currently required from: Rory Liu, Paul Menzel, Zhuohao Lee, Alan Huang. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61267 )
Change subject: drivers/net/r8168: Add ASPM control mechanism ......................................................................
Patch Set 2:
(2 comments)
File src/drivers/net/chip.h:
https://review.coreboot.org/c/coreboot/+/61267/comment/9e9fb85e_7f662bdb PS2, Line 35: /* Allow kernel driver to enable ASPM L1.2. */ : bool enable_aspm; So coreboot already has a Kconfig option to enable ASPM on PCIe links (PCIEXP_ASPM, see https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src... .
Should we just use that instead in the driver code?
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/61267/comment/8ca0c553_1e5b57d1 PS2, Line 252: struct drivers_net_config *config = dev->chip_info; : if (!config || !config->enable_aspm) : return; Should we just change this to ``` if (!CONFIG(PCIEXP_ASPM)) return; ```