23 Sep
2020
23 Sep
'20
3:32 p.m.
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45576 )
Change subject: ec/hp/kbc1126: Support using a different GPE ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45576/1/src/ec/hp/kbc1126/Kconfig File src/ec/hp/kbc1126/Kconfig:
https://review.coreboot.org/c/coreboot/+/45576/1/src/ec/hp/kbc1126/Kconfig@1... PS1, Line 16: default 0x16
Nit, maybe move above so that the _CBFS config sticks with the if below?
done
--
To view, visit https://review.coreboot.org/c/coreboot/+/45576
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b78567e1387c96bf173e4370aa3c836bbddac0b
Gerrit-Change-Number: 45576
Gerrit-PatchSet: 2
Gerrit-Owner: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Reviewer: Iru Cai mytbk920423@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Sep 2020 13:32:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment