Attention is currently required from: Patrick Georgi, Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Marco Chen, Karthik Ramasubramanian. Vitaly Rodionov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61448 )
Change subject: drivers/i2c/cs35l53: Add driver for generating device in SSDT ......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61448/comment/4182660b_e0a5cc03 PS2, Line 8:
Please start by describing the problem. […]
Done
https://review.coreboot.org/c/coreboot/+/61448/comment/24cd4358_74125e56 PS2, Line 9: This driver uses the ACPI Device Property interface to generate
Mention the full chip vendor and name here?
Done
https://review.coreboot.org/c/coreboot/+/61448/comment/4c5ad8af_c71fb710 PS2, Line 11: the kernel.
Is that documented in a datasheet? If so, please mention the name and revision.
Done
https://review.coreboot.org/c/coreboot/+/61448/comment/b3225dda_69d7ba49 PS2, Line 12:
Maybe paste the new log messages from coreboot, and mention on what device you tested this.
Unfortunately, Cirrus Logic have no access to this new HW at the moment, we relay on customer testing results. Vendors requesting this driver to be upstreamed before they will build new coreboot.
File src/drivers/i2c/cs35l53/cs35l53.c:
https://review.coreboot.org/c/coreboot/+/61448/comment/b6e0e52a_b953bafb PS2, Line 56: AAD
`Add` […]
Done
https://review.coreboot.org/c/coreboot/+/61448/comment/3a488879_11384fdf PS2, Line 105: 5
nit: […]
Done