[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: Disable TBT if platform is only USB3

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43771 )

Change subject: mb/google/volteer: Disable TBT if platform is only USB3
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43771/2/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/romstage.c:

https://review.coreboot.org/c/coreboot/+/43771/2/src/mainboard/google/voltee... 
PS2, Line 34: 	/* If the DB is USB3 disable TBT on the platform */
            : 	if (fw_config_probe(FW_CONFIG(DB_USB, USB3_ACTIVE)) ||
            : 		fw_config_probe(FW_CONFIG(DB_USB, USB3_PASSIVE))) {
            : 		mem_cfg->TcssItbtPcie0En = 0;
            : 		mem_cfg->TcssItbtPcie1En = 0;
            : 		mem_cfg->TcssDma0En = 0;
            : 		mem_cfg->TcssDma1En = 0;
            : 	}
> Does it matter where this is done? I can move it to the devicetree but both of these accomplish the  […]

the thing to check is whether anything depends on this configuration
before the device tree params are applied. for example, PchHdaEnable
disable is done in this section quite deliberately to disable some
initialization.