rushikesh s kadam has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31682 )
Change subject: driver/intel/ish: add ish chip driver support ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31682/4/src/drivers/intel/ish/ish.c File src/drivers/intel/ish/ish.c:
https://review.coreboot.org/#/c/31682/4/src/drivers/intel/ish/ish.c@43 PS4, Line 43: firmware-variant Should this be "firmware-name" as in kernel driver here https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1...