Attention is currently required from: Furquan Shaikh, Caveh Jalali, Matthew Blecker, Tim Wawrzynczak.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56928 )
Change subject: mb/google/poppy/variants/atlas: stop setting touchscreen probed=1
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS4:
The Atlas touchscreen device has had generic.probed=1 since it was first added in https://review. […]
For background: Non-Google/Chromium folk’s access to these bug reports is restricted, and, therefore, as you did, summarizing these issues in the commit message, is very important.
Patchset:
PS5:
This should be unnecessary anyway, the `probed` property is intended to allow the kernel to send i2c […]
Thank you for the explanation. Matthew, I am sorry for being a pain in your neck, but could you add Tim’s explanation to the commit message too. I know, so much text for a oneline change, but I think it’s good to document it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56928
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b90690b0591e8748d7a007f8cc9688d393e59db
Gerrit-Change-Number: 56928
Gerrit-PatchSet: 5
Gerrit-Owner: Matthew Blecker
matthewb@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Matthew Blecker
matthewb@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 13 Aug 2021 08:28:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matthew Blecker
matthewb@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment