[coreboot-gerrit] Change in coreboot[master]: soc/*/mp_init: Increase timeout to 1 s

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34587 )

Change subject: soc/*/mp_init: Increase timeout to 1 s
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34587/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34587/3//COMMIT_MSG@12 
PS3, Line 12: most mp_run_on_all_cpus calls
> The first call in post_mp_init should never fail as all APs are idle, due to previous synchronisation in mp init.

Right. But that could change if another call is added before the first call.
> Sounds good, but how to know if the caller doesn't care about a special timeout? Do we need a special (non default) timeout?

Fair point. 1 second is long enough that I think it should help all callers. How about getting rid of the expire_us parameter for now and just setting it to 1 second always? If there is a case that comes up in the future which requires more than a second, we can add a different API for that.