Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41759 )
Change subject: soc/intel/tigerlake: Add Type-C IOM base address and size macro
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41759/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41759/3//COMMIT_MSG@17
PS3, Line 17: EST=Built and booted on Volteer.
Hi John,
Can we have more directed testing here? We've run into an issue recently where some TBT patches had "Built and booted on Volteer" as their test string, but broke TBT.
Please test this with an internal version of the IOM driver (along with either extcon or the cros-ec-typec patches I provided), so that we have confidence that the following still work:
- USB4/TBT enumeration
- DP + USB3 alternate mode.
- USB SuperSpeed thumb drive enumeration.
The above should still work for the following configurations:
- Both Type C ports
- Both cable orientations.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41759
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70d88ba318087f7acacd1ee84609c9db5b65f907
Gerrit-Change-Number: 41759
Gerrit-PatchSet: 3
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Prashant Malani
pmalani@google.com
Gerrit-Comment-Date: Mon, 01 Jun 2020 19:30:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment