Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36845 )
Change subject: security/vboot: Remove vboot_set_selected_region() ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36845/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36845/2//COMMIT_MSG@7 PS2, Line 7: Remove vboot_set_selected_region() s/set/get/
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/common.c... PS1, Line 114: {
Added a vboot_is_slot_selected() check in vboot_locate(). […]
Yes, that will resolve that problem.
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/common.c... PS1, Line 122: vboot_named_region_device
Ack
There's still vbnv_flash() using vboot_named_region_device_rw().
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/vboot_lo... File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/vboot_lo... PS1, Line 453: vboot_set_selected_region(region_device_region(&fw_main));
Honestly I'm not sure how to deal with this now.
You are still relying on it for vboot_is_slot_selected().