Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75738?usp=email )
Change subject: soc/intel/xeon_sp: Fix HEST table length ......................................................................
soc/intel/xeon_sp: Fix HEST table length
"current" points to the start of HEST table, so "next - current" already includes the size of its header, no need for increment here. This issue was found on SPR-SP platform. The length of HEST table is now correct with this patch.
Change-Id: I6ff1e8e24612b7356772d582ff9a7e53863419db Signed-off-by: Jeff Li lijinfeng01@inspur.com Signed-off-by: Ziang Wang ziang.wang@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/75738 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Lean Sheng Tan sheng.tan@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com --- M src/soc/intel/xeon_sp/ras/hest.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Nico Huber: Looks good to me, but someone else must approve Lean Sheng Tan: Looks good to me, approved build bot (Jenkins): Verified Eric Lai: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/xeon_sp/ras/hest.c b/src/soc/intel/xeon_sp/ras/hest.c index 9eb54d9..2da720a 100644 --- a/src/soc/intel/xeon_sp/ras/hest.c +++ b/src/soc/intel/xeon_sp/ras/hest.c @@ -65,7 +65,7 @@ next = hest + 1; next += acpi_hest_add_ghes(next); hest->error_source_count += 1; - header->length += next - current; + header->length = next - current; return header->length; }