[coreboot-gerrit] [XS] Change in coreboot[main]: src/include: Introduce a new BIT_FLAG_32(x) macro

[Saurabh Mishra (Code Review)]

Attention is currently required from: Ashish Kumar Mishra, Jérémy Compostella, Martin Roth, Pratikkumar V Prajapati, Subrata Banik.

Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/84142?usp=email )

Change subject: src/include: Introduce a new BIT_FLAG_32(x) macro
......................................................................

Patch Set 14:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84142/comment/29d0bc1a_0058df3e?usp... :
PS14, Line 7: src/include: Introducing a new SET_32_BIT_FLAG(x) macro.
> Remove the . at the end of line.

Acknowledged

https://review.coreboot.org/c/coreboot/+/84142/comment/d61efe96_961fc49d?usp... :
PS14, Line 9: This new macro addition ensures the shift operation does not
> This is a generic macro. Please describe the macro here. […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/84142/comment/21046f58_a8f90382?usp... :
PS14, Line 12: On a 64-bit system, 1ul will typically be 64 bits wide.
             : The left shift can accommodate values of x up to 63 without overflowing.
             : But `GEN_PMCON_A` register width is 32-bit hence, adding new SET_32_BIT_FLAG(x)
             : to limit the register to max 32-bit width.
> yes

Done