Attention is currently required from: Máté Kukri, Paul Menzel, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81529?usp=email )
Change subject: mb/dell/optiplex_9020: Implement late HWM initialization
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/dell/optiplex_9020/mainboard.c:
https://review.coreboot.org/c/coreboot/+/81529/comment/a743eaf2_1294e3c6 :
PS9, Line 296: static uint8_t get_temp_target(void)
: {
: uint8_t val = rdmsr(0x1a2).lo >> 8 & 0xff;
: if (!val)
: val = 20;
: return 0x95 - val;
: }
:
: static uint16_t get_pkg_power(void)
: {
: uint8_t rapl_power_unit = rdmsr(0x606).lo & 0xf;
: if (rapl_power_unit)
: rapl_power_unit = 2 << (rapl_power_unit - 1);
: uint16_t pkg_power_info = rdmsr(0x614).lo & 0x7fff;
: if (pkg_power_info / rapl_power_unit > 0x41)
: return 32;
: else
: return 16;
: }
I'm OK dealing with this in a follow-up
sounds like a good plan
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81529?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43
Gerrit-Change-Number: 81529
Gerrit-PatchSet: 10
Gerrit-Owner: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Leah Rowe
leahleahrowerowe@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 24 Apr 2024 17:42:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Máté Kukri
kukri.mate@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment