Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41030 )
Change subject: soc/intel/gpio: set default value for RXEVCFG in native mode
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41030/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41030/1//COMMIT_MSG@9
PS1, Line 9: (Intel document #549921
Aaron, on what chipset did that happen and which functions didn't do it right?
I want to say apollolake, skylake, or glk. I did a brief search and found apollolake had an issue on LPC block: https://review.coreboot.org/c/coreboot/+/16426 That was involving the termination pulls. I recall an EMMC issue as well, however I didn't hvae time to dig that one up.
I'm not sure we want to figure out the whole list of things that are or are not updated when in NF mode because if we write a value that is overwritten by the IP block that implements once we put the pad in NF mode then there's no regression. However, if we have instances of different behavior from experience why would we risk changing current behavior?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41030
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia667ae4bac4198fe269091050bf067c0a488289a
Gerrit-Change-Number: 41030
Gerrit-PatchSet: 1
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 May 2020 20:51:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment