Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41668 )
Change subject: jasperlake: enable DPTF functionality for dedede ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41668/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41668/2/src/mainboard/google/dedede... PS2, Line 144: register "Device4Enable" = "1" Can we add a comment that Device4 is DTT (AKA DPTF)?
https://review.coreboot.org/c/coreboot/+/41668/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/41668/2/src/mainboard/google/dedede... PS2, Line 35: 1000, /* TimeWindowMinimum */ : 1000, /* TimeWindowMaximum */ Power limits averaged over a 1 second window? Is that normal for the small cores?