Enrico Granata has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31998 )
Change subject: mb/google/hatch: Add SX9310 SAR0 sensor
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31998/1/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31998/1/src/mainboard/google/hatch/variants/...
PS1, Line 240: register "reg_prox_ctrl0" = "0x10"
I don't really know :) I got them from src/mainboard/google/poppy/variants/nocturne/devicetree.cb . […]
Mostly curious. It's fine to leave them in. It is entirely likely that we will need to work with the vendor to get proper values later on, but feel free to use Nocturne's setup for the time being.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31998
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63943cc7da5ff56f6ef6dcbd99bb8f8f031e8bf7
Gerrit-Change-Number: 31998
Gerrit-PatchSet: 2
Gerrit-Owner: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Enrico Granata
egranata@chromium.org
Gerrit-Reviewer: Enrico Granata
egranata@google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 20 Mar 2019 21:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Evan Green
evgreen@chromium.org
Comment-In-Reply-To: Enrico Granata
egranata@google.com
Gerrit-MessageType: comment