Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43277 )
Change subject: mb/mainboard/dedede: update GPIO table for Boten ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43277/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/gpio.c:
https://review.coreboot.org/c/coreboot/+/43277/2/src/mainboard/google/dedede... PS2, Line 10: The blank line is not needed.
https://review.coreboot.org/c/coreboot/+/43277/2/src/mainboard/google/dedede... PS2, Line 29: /* E2 : CLK_24M_WCAM */ The alignment of the colon is not helpful in my opinion. But if it’s how it’s done in the other `gpio.c` files, leave it.
https://review.coreboot.org/c/coreboot/+/43277/2/src/mainboard/google/dedede... PS2, Line 42: The blank line is not needed.