Attention is currently required from: Arthur Heymans, Elyes Haouas, Felix Singer, Lance Zhao, Tim Wawrzynczak.
Hello Elyes Haouas, Felix Singer, Lance Zhao, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76143?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Code-Review+1 by Elyes Haouas, Code-Review+2 by Felix Singer, Code-Review+2 by Tim Wawrzynczak, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: acpi/acpi.c: Move ACPI header creation to a function ......................................................................
acpi/acpi.c: Move ACPI header creation to a function
This reduces boilerplate. One functional difference is that SSDT no longer has oem_revision set to 42.
Signed-off-by: Arthur Heymans arthur@aheymans.xyz Change-Id: Id2e54d61970294e028a61ba86c07c5482784e307 --- M src/acpi/acpi.c 1 file changed, 49 insertions(+), 246 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/76143/3