Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31651 )
Change subject: lint/clang-format: set to 96 chars per line
......................................................................
Patch Set 2:
Wow, I didn't expect that we'd let blunt clang-format
patches in. Now I understand what the fuss is about.
If people want to dully use a formating tool (which
probably can never decide if obeying a soft limit is
reasonable), that tool should be set to 80 chars.
So, yeah, I guess we should revert the clang-format
part at least.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31651
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9293a69d1bea900da36501cde512004d0695ad37
Gerrit-Change-Number: 31651
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Fri, 08 Mar 2019 23:50:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment