Attention is currently required from: Tim Wawrzynczak, Benson Leung, Prashant Malani.
Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61388 )
Change subject: brya: Add custom PLD fields to device tree
......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/61388/comment/695be230_8b95d14a
PS6, Line 658: 1"
`PLD_HORIZONTAL_POSITION_CENTER`
Done
https://review.coreboot.org/c/coreboot/+/61388/comment/f270b688_4fbd64eb
PS6, Line 655: register "use_custom_pld" = "true"
: register "custom_pld.visible" = "true"
: register "custom_pld.panel" = "PLD_PANEL_LEFT"
: register "custom_pld.horizontal_position" = "1"
: register "custom_pld.shape" = "PLD_SHAPE_OVAL"
: register "custom_pld.group" = "ACPI_PLD_GROUP(1, 1)"
We can clean up some of the wordiness like so: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61388
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea975a4f436a204d4edd19fad0f5652fb44c6301
Gerrit-Change-Number: 61388
Gerrit-PatchSet: 7
Gerrit-Owner: Won Chung
wonchung@google.com
Gerrit-Reviewer: Benson Leung
bleung@chromium.org
Gerrit-Reviewer: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Benson Leung
bleung@chromium.org
Gerrit-Attention: Prashant Malani
pmalani@chromium.org
Gerrit-Comment-Date: Thu, 27 Jan 2022 19:05:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment