Attention is currently required from: Cliff Huang, Jérémy Compostella, Kapil Porwal, Pranava Y N, Ravishankar Sarawadi, Saurabh Mishra.
Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83635?usp=email )
Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till romstage ......................................................................
Patch Set 73:
(3 comments)
File src/soc/intel/pantherlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/83635/comment/318789c2_1b23cd55?usp... : PS73, Line 45: SOC_INTEL_PANTHERLAKE_U_H this is misleading,
there are 3 SoC flavours for PTL
1. PTL-U - 15W 2. PTL-H - 25W 3. PTL-H - 45W
now #1 and #2 are almost identical in usage of IOs (HSIO/LSIO) but #3 looks different hence, if you need different Kconfig to select between HSIO differences like 10 PCIe RP vs 12 PCIe RP then this Kconfig won't help.
lets use two Kconfig
1. SOC_INTEL_PANTHERLAKE_U_H (which cater to support both 15W and 25W SoC). I know the TDP would be different and for that we have enum already created to handle the chipset.cb PLx limits
2. SOC_INTEL_PANTHERLAKE_H (which only supports 45W SoC)
You can now use either #1 and #2 from above Kconfig to select the correct HSIO config. Now Google/fatcat will select SOC_INTEL_PANTHERLAKE_U_H.
https://review.coreboot.org/c/coreboot/+/83635/comment/00242f17_4e798ee2?usp... : PS73, Line 269: SOC_INTEL_ACPI_GPIO_PINCTRL_COMPACT I thought GPIO CL will introduce this Kconfig ?
File src/soc/intel/pantherlake/chipset.cb:
https://review.coreboot.org/c/coreboot/+/83635/comment/ef836ed2_4f0449a5?usp... : PS72, Line 5: PTL_U_H_POWER_LIMITS
Hi Subrata, i have added the corresponding 15W/25W/45W into enum.
Additionally, doc doesn't specify the PL2 value, rather it says that the PL2 is same as ARL-H on same segment. I don't know the PL2 value for ARL as well. Can you please help here. Unable to find PL4 as well in the doc.
I have used the override of Pl2, Pl4 settings from FSP.
may be you ensure the doc are being update, referring to FSP code is not ideal because not everyone has FSP source access.
please mark this after you are adding a TODO saying update the doc