Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44805 )
Change subject: mb/google/kaisa: Override power limits configuration
......................................................................
Patch Set 1: Code-Review-2
Hi David,
So this is a incorrect approch as we already have `src/mainboard/google/hatch/variants/baseboard/mainboard.c` shared between the boards.
What you probably need to do here to generalise it as parameteric on the variants is have each variant have a header with the `#define` differences. This way when each board is compiled the common mainboard.c will get the correct constants.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44805
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b621a8cc1749ee52a9f16a7ad2ae7a7aa0f7a5a
Gerrit-Change-Number: 44805
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Andrew McRae
amcrae@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 26 Aug 2020 07:59:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment