Attention is currently required from: Shelley Chen, Julius Werner, Yu-Ping Wu.
Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68871 )
Change subject: mem_chip_info: Update to new format
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/68871/comment/889a02e2_4eeff9cc
PS2, Line 132: }
@Yu-Ping: I wrote this as a best guess of how I assume it would probably fit together, but I don't k […]
Hi julius:
MTK structure mr8_sensity array stores each rank's density.
For each channel density, they are always equal.
Take rank_nums = 2 as example:
total_size == mtk_dram_size()
== ddr->mrr_info.mr8_density[0] + ddr->mrr_info.mr8_density[1]
CH0/RK0 size: ddr->mrr_info.mr8_density[0] / 2
CH0/RK1 size: ddr->mrr_info.mr8_density[1] / 2
CH1/RK0 size: ddr->mrr_info.mr8_density[0] / 2
CH1/RK1 size: ddr->mrr_info.mr8_density[1] / 2
Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If34e6857439b6f6ab225344e5b4dd0ff11d8d42a
Gerrit-Change-Number: 68871
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: Xi Chen
xixi.chen@mediatek.com
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 27 Oct 2022 06:17:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment