Attention is currently required from: Arthur Heymans, Felix Held, Lance Zhao, Paul Menzel.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76007?usp=email )
Change subject: acpi/acpigen.c: Ignore compiler warning about stack overflowing
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/76007/comment/aca479ac_0deafa55 :
PS1, Line 1769: #pragma GCC diagnostic ignored "-Wstack-usage="
another option could be to use the heap here; the memory will actually be returned to the heap if you call free() before the next malloc. This is definitely safe, but compilers aren't perfect yet
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76007?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d445d151db5e6cc7b6e13bf74ce81007d819f1d
Gerrit-Change-Number: 76007
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 24 Jun 2023 14:29:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment