Attention is currently required from: Lance Zhao, Bora Guvendik, Hannah Williams, Jakub Czapiga, Jérémy Compostella, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro.
Hello Bora Guvendik, Lance Zhao, build bot (Jenkins), Hannah Williams, Jérémy Compostella, Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/73113
to look at the new patch set (#4).
Change subject: acpi: Add function to print debug string directly from formatted string ......................................................................
acpi: Add function to print debug string directly from formatted string
Generate formatted string and generate code for printing this string in ACPI.
ex: pcie_rp = 1 acpigen_write_debug("calling _ON for RP: %u", pcie_rp);
will generate ACPI code:
Debug = "calling _ON for RP: 1"
With this new function, the following functions won't be needed and therefore to be removed: acpigen_concatenate_string_string() acpigen_concatenate_string_int() acpigen_write_debug_concatenate_string_string() acpigen_write_debug_concatenate_string_int()
BRANCH=firmware-brya-14505.B TEST=Add above functions in the acpigen code and check the generated SSDT table after OS boot.
Signed-off-by: Cliff Huang cliff.huang@intel.com Change-Id: Id4a42e5854516a22b7bc4559c2ed08680722c5ba --- M src/acpi/acpigen.c M src/include/acpi/acpigen.h 2 files changed, 44 insertions(+), 42 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/73113/4