Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34145 )
Change subject: src/cpu/intel: Add sanity check for cpu turbo mode capability
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34145/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34145/9//COMMIT_MSG@14
PS9, Line 14: TEST=Built and boot up to kernel.
On what device?
https://review.coreboot.org/c/coreboot/+/34145/9/src/cpu/intel/turbo/turbo.c
File src/cpu/intel/turbo/turbo.c:
https://review.coreboot.org/c/coreboot/+/34145/9/src/cpu/intel/turbo/turbo.c...
PS9, Line 86: * Determine the current state of Turbo and cache it for later.
: * Turbo is a package level config so it does not need to be
: * enabled on every core.
Please use the full text width.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34145
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1bc37fb339b4a0bb6a7cdc6cd4391575b22b55a
Gerrit-Change-Number: 34145
Gerrit-PatchSet: 9
Gerrit-Owner: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jul 2019 12:56:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment