Attention is currently required from: Felix Singer, Furquan Shaikh, Tim Wawrzynczak. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56209 )
Change subject: mb/google/volteer/baseboard: Configure chipset_lockdown seperately ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56209/comment/bebe88a6_90b5894d PS2, Line 7: seperately sep*a*rately
https://review.coreboot.org/c/coreboot/+/56209/comment/0c97effa_fb21c732 PS2, Line 15: : Thus, move `chipset_lockdown` out of `common_soc_config` in the : baseboard devicetree and configure it seperately. :
Should the `chipset_lockdown` be moved to chipset.cb: https://review.coreboot. […]
It should be a Kconfig. And default to CHIPSET_LOCKDOWN_COREBOOT.
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/56209/comment/01cfb0b9_53b456b9 PS2, Line 328: CHIPSET_LOCKDOWN_COREBOOT
Technically, no https://review.coreboot. […]
Ack