Attention is currently required from: Jonathan Zhang, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68878 )
Change subject: soc/intel/cmn/block/acpi: enable BERT table without crashlog
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File src/soc/intel/common/block/acpi/acpi_bert.c:
https://review.coreboot.org/c/coreboot/+/68878/comment/e0e1d7da_565ef6f3
PS2, Line 9:
: #if (CONFIG(SOC_INTEL_CRASHLOG))
This should not be needed. Split off things that are only needed for crashlog in a separate function and use C instead of CPP to guard it. The compiler will optimize it out it will still be build.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68878
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I323ca889eef2b246fc4e062582d2d11b4213316f
Gerrit-Change-Number: 68878
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Sat, 12 Nov 2022 08:03:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment