Patrick Rudolph (siro@das-labor.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11247
-gerrit
commit 2eeb12116803714b67cf777278b7e64dc852fa94 Author: Patrick Rudolph siro@das-labor.org Date: Sun Aug 16 17:06:30 2015 +0200
intel raminit: add sanity check
Make sure edge write test results are sane. Check rn.all to make sure rn.start and rn.end are valid. Most likely the following test is going to fail on the same rank anyway.
Change-Id: Ifa601406e6c74ceb8d70063be5ce1bf6bc512c18 Signed-off-by: Patrick Rudolph siro@das-labor.org --- src/northbridge/intel/sandybridge/raminit_native.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/northbridge/intel/sandybridge/raminit_native.c b/src/northbridge/intel/sandybridge/raminit_native.c index 9df102a..286493b 100644 --- a/src/northbridge/intel/sandybridge/raminit_native.c +++ b/src/northbridge/intel/sandybridge/raminit_native.c @@ -3129,6 +3129,8 @@ static void discover_edges_write_real(ramctr_timing * ctrl, int channel, max(rn.start + ctrl->edge_offset[i], lower[lane]); upper[lane] = min(rn.end - ctrl->edge_offset[i], upper[lane]); + if (rn.all || lower[lane] > upper[lane]) + die("edge write discovery failed"); edges[lane] = (lower[lane] + upper[lane]) / 2;
}