Attention is currently required from: Maulik V Vaghela, Paul Menzel, Mario Scheithauer, Werner Zeh, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56633 )
Change subject: soc/intel/elkhartlake: Add PSE TSN support
......................................................................
Patch Set 23:
(1 comment)
File src/soc/intel/elkhartlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133802):
https://review.coreboot.org/c/coreboot/+/56633/comment/6be564c2_6958863f
PS23, Line 141: (params->PseTsnGbePhyInterfaceType[i]<SGMII_plus) ?
spaces required around that '<' (ctx:VxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56633
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3807ff5a4578be7b2c67064525fa5099950986a
Gerrit-Change-Number: 56633
Gerrit-PatchSet: 23
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 19 Nov 2021 11:06:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment