Attention is currently required from: Robert Zieba, Jon Murphy, Rob Barnes, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66572 )
Change subject: util/amdfwtool/amdfwread: Update relative_offset function
......................................................................
Patch Set 13:
(2 comments)
File util/amdfwtool/amdfwread.c:
https://review.coreboot.org/c/coreboot/+/66572/comment/9d99db77_78fc59a4
PS13, Line 38: /* Intentional fall-through */
Prefer 'fallthrough;' over fallthrough comment
Please fix.
https://review.coreboot.org/c/coreboot/+/66572/comment/bfa90e82_2bf10025
PS13, Line 40: & FILE_REL_MASK
Instead of silently dropping the top bits, can we check `if addr < FILE_REL_MASK then return addr else error`. You will need to move the `return addr & FILE_REL_MASK;` to the physical case above. That removes the need for the fall through.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66572
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74603dd08eda87393c14b746c4435eaf2bb34126
Gerrit-Change-Number: 66572
Gerrit-PatchSet: 13
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 20 Oct 2022 16:10:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment