Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44188 )
Change subject: ec/google/chromeec: Add helper to request AP reset
......................................................................
Patch Set 1:
So there will be some instructions continuing to execute after the AP sends the command and before the EC can perform the reset; I think a call to `halt()` is probably a good idea here. I'm just trying to think where the best place for it is... I'm thinking here is probably the better choice, otherwise it needs to be duplicated for other boards that will require this workaround as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44188
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01d7dfec72a8a3f6d2c4844bc062672e494860d8
Gerrit-Change-Number: 44188
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Aug 2020 19:21:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment