Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36193 )
Change subject: arch/acpi.h: Use of typedef for acpi_vfct
......................................................................
Patch Set 1:
Patch Set 1: Code-Review-1
Again, why?
Thanks for your review and comments!!!
I agree with you but after analyzing this file "/coreboot/src/arch/x86/include/arch/acpi.h", since almost all other struct defined in this file has used typedef that is the reason I have tried to provide the same kind of coding style as a base.
Also, the typedef would be better for readability purposes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36193
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I875ef2fa31e65750233fa8da2b76d8db5db44f2d
Gerrit-Change-Number: 36193
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1002476
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Name of user not set #1002476
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Oct 2019 06:38:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment