Attention is currently required from: Bora Guvendik, Hannah Williams, Jérémy Compostella, Li1 Feng, Pranava Y N, Subrata Banik, Tanu Malhotra.
Hello Cliff Huang, Hannah Williams, Jérémy Compostella, Li1 Feng, Pranava Y N, Subrata Banik, Tanu Malhotra,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84739?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Jérémy Compostella
Change subject: mb/google/fatcat: support ISH
......................................................................
mb/google/fatcat: support ISH
Enable ISH PCI device and update gpio GPP_D05, GPP_D06 configuration.
BUG=b:370984186
TEST=verified lspci shows ISH and ISH UART shows ISH firmware log on fatcat
Change-Id: I2b6eb39fe7b07fcabc255d66df4aa0aa2865df79
Signed-off-by: Bora Guvendik bora.guvendik@intel.com
---
M src/mainboard/google/fatcat/Kconfig
M src/mainboard/google/fatcat/variants/fatcat/gpio.c
M src/mainboard/google/fatcat/variants/fatcat/overridetree.cb
3 files changed, 20 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/84739/3
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84739?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b6eb39fe7b07fcabc255d66df4aa0aa2865df79
Gerrit-Change-Number: 84739
Gerrit-PatchSet: 3
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Li1 Feng
li1.feng@intel.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com