Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35294 )
Change subject: superio/common: fix generic ssdt ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
there is indeed a bug in the code, but I don't think that this patch is the proper fix in the current state. See chapter A.3.3. of the ISA PNP spec v 1.0a
https://review.coreboot.org/c/coreboot/+/35294/1/src/superio/common/generic.... File src/superio/common/generic.c:
https://review.coreboot.org/c/coreboot/+/35294/1/src/superio/common/generic.... PS1, Line 122: ITR2 this should probably be something like ITT2 (or rather this and the one before with a 1 instead of a 2, since this is 0-indexed in the coreboot SIO code)